Revert "fix(ui): prevent lossy cron rewrites + redesign routine triggers tab" #5725

PR
PR description

Thinking Path

  • Paperclip orchestrates AI agents through visible, governable task and routine workflows.
  • Routines are the recurring-work surface where operators configure schedules, runs, and activity.
  • PR #3569 moved routine operational tabs into the right-hand properties panel while also redesigning the routine trigger editor.
  • The current product request is to remove that routine properties right-tab change for now and come back to it later.
  • The cleanest way to do that is a direct revert of #3569 on top of current master, which already includes the #5703 revert.
  • This pull request restores the pre-#3569 routine trigger/detail behavior and removes the right-tab properties-panel routine layout.
  • The benefit is a simple, reviewable rollback with no schema or API changes.

What Changed

  • Reverted #3569: fix(ui): prevent lossy cron rewrites + redesign routine triggers tab.
  • Restored the previous RoutineDetail inline tabs and trigger editing flow.
  • Restored the earlier ScheduleEditor implementation.
  • Removed the UI components and tests introduced by #3569: ConfirmDialog, TriggerDialog, TriggerListCard, and ScheduleEditor.test.ts.

Verification

  • git diff --check origin/master..HEAD
  • pnpm vitest run ui/src/pages/Routines.test.tsx ui/src/components/RoutineHistoryTab.test.tsx
  • pnpm --filter @paperclipai/ui typecheck

Notes:

  • pnpm install --frozen-lockfile was run in the clean worktree before verification. It completed with known workspace bin-link warnings for paperclip-plugin-dev-server because the plugin SDK dist/dev-cli.js has not been built in that fresh worktree.
  • Routines.test.tsx emitted existing Radix dialog accessibility warnings during the test run; the tests passed.

Screenshots

This is a direct revert of #3569. The visual state after this PR corresponds to the old screenshot from #3569, and the state being removed corresponds to the new/right-panel screenshots from #3569.

Before this revert After this revert
routine-triggers-before-this-revert routine-triggers-after-this-revert

Right-hand properties panel state removed by this revert:

routine-properties-panel-removed

Risks

  • Low technical risk: this is a clean Git revert of a UI-only PR.
  • Product risk: #3569 also fixed lossy cron editing and added broader schedule presets, so this rollback intentionally removes those improvements along with the right-tab routine layout.
  • Follow-up risk: if we want only the schedule-editor fixes back later, they should be reintroduced separately from the routine properties-panel layout.

For core feature work, check ROADMAP.md first and discuss it in #dev before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See CONTRIBUTING.md.

Model Used

  • OpenAI Codex, GPT-5 coding agent, tool-enabled with local shell and GitHub CLI access. Context window size was not exposed in this session.

Checklist

  • I have included a thinking path that traces from project context to this change
  • I have specified the model used (with version and capability details)
  • I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work
  • I have run tests locally and they pass
  • I have added or updated tests where applicable
  • If this change affects the UI, I have included before/after screenshots
  • I have updated relevant documentation to reflect my changes
  • I have considered and documented any risks above
  • I will address all Greptile and reviewer comments before requesting merge
CUT
cutter bot commented just now

Cutter Summary

The routine's Triggers, Runs, Activity, and History tabs and the Add trigger form moved out of a right-side Properties panel and now sit inline beneath the routine fields on the detail page, and the schedule editor's day-of-week control changed from single-letter S/M/T/W/T/F/S buttons inside a trigger dialog to a Mon–Sun button row in an inline preset-based editor.